From: Junio C Hamano Date: Tue, 04 Feb 2014 18:37:24 GMT Subject: Re: [PATCH 7/8] combine-diff: Fast changed-to-all-parents paths scanning Message-ID: In-Reply-To: <20140204163400.GA20436@tugrik.mns.mnsspb.ru> Kirill Smelkov writes: >> if we did not want to reinvent the whole tree walking thing, which >> would add risks for new bugs and burden to maintain this and the >> usual two-tree diff tree walking in sync. > > Junio, I understand it is not good to duplicate code and increase > maintenance risks.... > Instead I propose we switch to the new tree walker completely. I am not fundamentally opposed to the idea. We'll see what happens.