From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 03 Mar 2014 19:54:32 GMT
Subject: Re: [PATCH 2/2] branch: use skip_prefix
Message-ID: <xmqq4n3foy6f.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140228054613.GB32556@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Fri, Feb 28, 2014 at 12:04:19PM +0900, Brian Gesiak wrote:
>
>> From: modocache <modocache@gmail.com>
>
> Both your emailed patches have this, which is due to your author name
> not matching your sending identity. You probably want to set user.name,
> or if you already have (which it looks like you might have from your
> Signed-off-by), use "git commit --amend --reset-author" to update the
> author information.
>
>> The install_branch_config function reimplemented the skip_prefix
>> function inline. Use skip_prefix function instead for brevity.
>> 
>> Signed-off-by: Brian Gesiak <modocache@gmail.com>
>> Reported-by: Michael Haggerty <mhagger@alum.mit.edu>
>
> It's a minor thing, but usually these footer lines try to follow a
> chronological order. So the report would come before the signoff (and a
> further signoff from the maintainer would go after yours).
>
>> diff --git a/branch.c b/branch.c
>> index 723a36b..e163f3c 100644
>> --- a/branch.c
>> +++ b/branch.c
>> [...]
>
> The patch itself looks OK to me.
>
> -Peff

Thanks.  Queued and pushed out on 'pu' with fixups already.