From: Junio C Hamano Date: Tue, 15 Jul 2014 20:06:48 GMT Subject: Re: [PATCH v2 1/8] alloc.c: remove the alloc_raw_commit_node() function Message-ID: In-Reply-To: <20140713064140.GA4852@sigill.intra.peff.net> Jeff King writes: > #define DEFINE_ALLOCATOR(name, type) \ > +static struct alloc_state name##_state; \ > void *alloc_##name##_node(void) \ > { \ > + return alloc_node(&name##_state, sizeof(type)); \ > } This is really nice. Thanks. > +static struct alloc_state commit_state; > + > void *alloc_commit_node(void) > { > static int commit_count; > - struct commit *c = alloc_raw_commit_node(); > + struct commit *c = alloc_node(&commit_state, sizeof(struct commit)); > c->index = commit_count++; > return c; > }