From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 Feb 2015 19:50:20 GMT
Subject: Re: [PATCH 2/2] builtin/push.c: make push_default a static variable
Message-ID: <xmqq4mqj2e4j.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150218192518.GA7891@peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Feb 18, 2015 at 11:08:34AM -0800, Junio C Hamano wrote:
> ...
>> Not very strongly either way.  Seeing the above does not bother me
>> too much, but I do not know how I would feel when I start seeing
>> 
>> 	val = git_config_book(k, v);
>> 	flip_bool(val, &flags, TRANSPORT_PUSH_FOLLOW_TAGS);
>> 
>> often.  Not having to make sure that the bit constant whose name
>> tends to get long is not misspelled is certainly a plus.
>
> I think it would be even nicer as:
>
>   git_config_bits(k, v, &flags, TRANSPORT_PUSH_FOLLOW_TAGS);

Maybe.  I do not feel very strongly either way.