From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 31 Mar 2015 20:28:32 GMT
Subject: Re: [PATCH] gitweb.conf.txt: fix typo
Message-ID: <xmqq4mp0rjwv.fsf@gitster.dls.corp.google.com>
In-Reply-To: <551A9BE9.3070907@gmail.com>

Jakub Narębski <jnareb@gmail.com> writes:

> On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
>> From: Jérôme Zago <git-patch@agt-the-walker.net>
>>
>> "build-time" is used everywhere else.
>>
>> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
>
> You are right, it is variable set during build process,
> not after project is built.
>
> ACK (for what it is worth).
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Thanks; the patch is linewrapped but I can fix it up.

It is funny to see an ack to a patch that is almost a year old,
though ;-)

>
>> ---
>>   Documentation/gitweb.conf.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
>> index 952f503..8b25a2f 100644
>> --- a/Documentation/gitweb.conf.txt
>> +++ b/Documentation/gitweb.conf.txt
>> @@ -482,7 +482,7 @@ project config.  Per-repository configuration
>> takes precedence over value
>>   composed from `@git_base_url_list` elements and project name.
>>   +
>>   You can setup one single value (single entry/item in this list) at build
>> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
>> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
>>   By default it is set to (), i.e. an empty list.  This means that gitweb
>>   would not try to create project URL (to fetch) from project name.
>>
>>