From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 May 2015 15:56:39 GMT
Subject: Re: [PATCH v2 01/12] t5520: implement tests for no merge candidates cases
Message-ID: <xmqq4mnos7ns.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACRoPnSCvitGfVKyqV7PJd_TzLJEs8U_mjYhaRy3KOFrWjBEwA@mail.gmail.com>

Paul Tan <pyokagan@gmail.com> writes:

> Hi Junio,
>
> On Thu, May 7, 2015 at 10:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Torsten Bögershausen <tboegi@web.de> writes:
>>
>>> In other words:
>>> test $(cat file) = file &&
>>
>> Is there a guarantee that file has a single word?  Can it be empty?
>> Can it contain "foo bar\n"?
>
> It can, but it should not ;-). But yes, this will need to be quoted as
> well to be safe. Whoops.

Yup.  I see that existing test (this script is ancient, isn't it?)
has the same issue of using backticks and not quoting sufficiently.

Perhaps we would want a clean-up-and-modernise step before this
patch to reduce patch noise.

Thanks.