From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 16 Oct 2015 17:42:49 GMT
Subject: Re: [PATCH] pull: add angle brackets to usage string
Message-ID: <xmqq4mhqg15y.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAMMLpeQPngq-xM2vN4uX6+k5-uoOXyP3p0wgLO9LOkWxWtZBEA@mail.gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

> 2015-10-16 10:36 GMT-06:00 Junio C Hamano <gitster@pobox.com>:
>> Makes sense, as all the other <placeholders> in the usage string are
>> bracketted.
>>
>> Does it make sense to do this for contrib/examples, which is the
>> historical record, though?
>
> I didn't know that contrib/examples was a historical record. The last
> patch I submitted, b7447679e84ed973430ab19fce87f56857b83068, also
> modified contrib/examples.

Yes, but that fixes historical "mistake", no?

With this, you are breaking historical practice by changing only one
instance to deviate from the then-current practice of saying
'options' without brackets.  It is based on the point of view that
considers anything inside <bracket> and a fixed string 'options' are
meant to be replaced by intelligent readers, which is as valid as
the more recent practice to consider only things inside <bracket>
are placeholders.