From: Junio C Hamano Date: Tue, 03 May 2016 15:47:55 GMT Subject: Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status Message-ID: In-Reply-To: Eric Sunshine writes: >>>> One previous commit (title: commit: add a commit.verbose config >>>> variable) introduced a new config variable named commit.verbose, >>>> so care should be taken that it would not affect the behavior of >>>> status. >>>> >>>> Another previous commit (title: "parse-options.c: make OPTION_COUNTUP >>>> respect "unspecified" values") changes the initial value of verbose >>>> from 0 to -1. This can cause git-status to display a verbose output even >>>> when it isn't supposed to. >>>> ... > > This patch's commit message is perhaps a bit too detailed about what > could have gone wrong in earlier patches in this series; indeed, it > misled Junio into thinking that patches in this series did break > behavior, when in fact, it was instead previous rounds of this series > which were buggy. Indeed. Please forget everything I said about expect-failure, if the top two paragraphs are describing breakages that this series does *NOT* introduce. I was misled by them--and others will, too. These two paragraphs do not belong to the log message. Thanks for clarifying.