From: Junio C Hamano Date: Mon, 16 May 2016 18:52:32 GMT Subject: Re: [PATCH 0/6] modernize t1500 Message-ID: In-Reply-To: Eric Sunshine writes: > On Tue, May 10, 2016 at 2:26 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >>> Junio C Hamano writes: >>> Subject: [PATCH 7/6] t1500: finish preparation upfront >>> >>> The earlier tests do not attempt to modify the contents of .git (by >>> creating objects or refs, for example), which means that even if >>> some earlier tests before "cp -R" fail, the tests in repo.git will >>> run in an environment that we can expect them to succeed in. >>> >>> Make it clear that tests in repo.git will be independent from the >>> results of earlier tests done in .git by moving its initialization >>> "cp -R .git repo.git" much higher in the test sequence. >>> >>> Signed-off-by: Junio C Hamano >>> --- >> >> I think the same logic applies to other preparatory things like >> creation of sub/dir in the working tree etc. > > Hmm, so are you suggesting a single 'setup' test at the start of > script which does the 'cp -R' and creates those other directories > needed by later tests? Exactly.