From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Oct 2016 22:41:59 GMT
Subject: Re: [PATCH] rev-list: restore the NUL commit separator in --header mode
Message-ID: <xmqq4m48j70o.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161019210448.aupphybw5qar6mqe@hurricane>

Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:

> +	touch expect &&
> +	printf "\0" > expect &&

What's the point of that "touch", especially if you are going to
overwrite it immediately after?

> +	git rev-list --header --max-count=1 HEAD | tail -n1 >actual &&

As "tail" is a tool for text files, it is likely unportable to use
"tail -n1" to grab the "last incomplete line that happens to contain
a single NUL".

> +	test_cmp_bin expect actual
> +'