From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 28 Sep 2017 04:37:36 GMT
Subject: Re: [PATCH] gitk: expand $config_file_tmp before reporting to user
Message-ID: <xmqq4lrn30bz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170928041417.28947-1-max@max630.net>

Max Kirillov <max@max630.net> writes:

> Tilda-based path may confise some users. First, tilda is not known
> for Window users, second, it may point to unexpected location
> depending on various environment setup.
>
> Expand the path to "nativename", so that ~/.config/git/gitk-tmp
> would be "C:\Users\user\.config\git\gitk-tmp", for example.
> It should be less cryptic

It might be less cryptic, but for those of us whose $HOME is a
looooooong path, ~/.config/git/gitk-tmp is much easier to understand
than the same path with ~/ expanded, which would push the part of
the filename that most matters far to the right hand side of the
dialog.

I somehow find this change just robbing Peter to pay Paul.

>  	} else {
> -	    error_popup "There appears to be a stale $config_file_tmp\
> +	    error_popup "There appears to be a stale \
> + \"[file nativename $config_file_tmp]\" \