From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Nov 2017 01:04:25 GMT
Subject: Re: [PATCH v1 4/8] commit: move print_commit_summary() to libgit
Message-ID: <xmqq4lq5oa1y.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <7849f0e9-24eb-89db-3524-dffdb00d82ad@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

> On 07/11/17 03:38, Junio C Hamano wrote:
>> Phillip Wood <phillip.wood@talktalk.net> writes:
>> 
>>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>>
>>> Move print_commit_summary() from builtin/commit.c to sequencer.c so it
>>> can be shared with other commands. The function is modified by
>>> changing the last argument to a flag so callers can specify whether
>>> they want to show the author date in addition to specifying if this is
>>> an initial commit.
>> 
>> A movement of a long function like this one really is easier if you
>> did not make any other unnecessary change in the same patch and then
>> made the change as a follow-up.
>
> I'm not sure what you mean by unnecessary, the original code called a
> file-local function author_date_is_interesting().

Yes, sorry, I missed the fact that author_date_is_interesting() is
not moving (and it is not moving for obvious reasons).