From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Feb 2018 23:21:24 GMT
Subject: Re: [PATCH v3 03/14] commit-graph: create git-commit-graph builtin
Message-ID: <xmqq4lmr6paj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <9c473af6-fc67-5612-07dd-54b2a6e24ff0@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

> I wanted to have the smallest footprint as possible in the objects
> directory, and the .git/objects directory currently only holds
> folders.

When we cull stale files from pack directory, we rely on the related
files to share pack-<hash>.* pattern.  It is better not to contaminate
the directory with unrelated cruft.

As this is purely optional auxiliary information used for optimization,
perhaps .git/objects/info is a better place?  I dunno.

In any case, even if its default position ends up in .git/objects/pack/,
if this thing conceptually does not have any ties with packs
(i.e. it is not a corruption if the graph file also described
topologies including loose objects, and it is not a corruption if
the graph file did not cover objects in all packs), then the end
user visible option name shouldn't say "--pack-dir".  "--graph-dir"
that defaults to .git/objects/pack/ might be acceptable but it still
feels wrong.