From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 03 May 2018 05:13:03 GMT
Subject: Re: [PATCH v3 06/12] get_short_oid: sort ambiguous objects by type, then SHA-1
Message-ID: <xmqq4ljpuxsw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180501184016.15061-7-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> +	/*
> +	 * Between object types show tags, then commits, and finally
> +	 * trees and blobs.
> +	 *
> +	 * The object_type enum is commit, tree, blob, tag, but we
> +	 * want tag, commit, tree blob. Cleverly (perhaps too

The missing comma between "tree blob"  on the second line made me
read this comment twice, which made me notice the lack of "and"
before "tag" on the previous line.

Assignment is "commit, tree, blob, and then tag" but we want "tag,
commit, tree and then blob", perhaps?