From: Junio C Hamano Date: Mon, 13 Aug 2018 21:21:29 GMT Subject: Re: [PATCH 04/24] convert.c: remove an implicit dependency on the_index Message-ID: In-Reply-To: <20180813161441.16824-5-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > Make the convert API take an index_state instead of assuming the_index > in convert.c. All external call sites are converted blindly to keep > the patch simple and retain current behavior. Individual call sites > may receive further updates to use the right index instead of > the_index. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- Nice progression from inside to outside, a bit by bit. Quite a pleasant read so far ;-)