From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Nov 2018 14:30:21 GMT
Subject: Re: [PATCH] remote-curl: die on server-side errors
Message-ID: <xmqq4lcluk1u.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <9a89e54e79593f6455b52e01d802695362f4ec21.1542062657.git.steadmon@google.com>

steadmon@google.com writes:

> When a smart HTTP server sends an error message via pkt-line,
> remote-curl will fail to detect the error (which usually results in
> incorrectly falling back to dumb-HTTP mode).

OK, that is a valid thing to worry about.

>
> This patch adds a check in discover_refs() for server-side error
> messages, as well as a test case for this issue.

This makes me wonder if discoer_refs() is the only place where we
ought to be checking for ERR packets but we are not.  Are there
other places that we also need a similar fix?