From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Oct 2019 03:37:16 GMT
Subject: Re: [PATCH v3 02/13] graph: handle line padding in `graph_next_line()`
Message-ID: <xmqq4l099x8z.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <056c95d4edc8748c513db8c159c5e3d347ffc894.1571183279.git.gitgitgadget@gmail.com>

"James Coglan via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: James Coglan <jcoglan@gmail.com>
>
> Now that the display width of graph lines is implicitly tracked via the
> `graph_line` interface, the calls to `graph_pad_horizontally()` no
> longer need to be located inside the individual output functions, where
> the character counting was previously being done.
>
> All the functions called by `graph_next_line()` generate a line of
> output, then call `graph_pad_horizontally()`, and finally change the
> graph state if necessary. As padding is the final change to the output
> done by all these functions, it can be removed from all of them and done
> in `graph_next_line()` instead.

Very well explained.