From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 28 Apr 2020 21:17:19 GMT
Subject: Re: [PATCH v3] git-credential-store: skip empty lines and comments from store
Message-ID: <xmqq4kt31fa8.fsf@gitster.c.googlers.com>
In-Reply-To: <20200428211407.GC56126@Carlos-MBP>

Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:

>> > +		if (!credential_from_url_gently(&entry, line.buf, 1) &&
>> > +		    entry.username && entry.password &&
>> >  		    credential_match(c, &entry)) {
>> >  			found_credential = 1;
>> >  			if (match_cb) {
>> 
>> Hmph, so the idea is, instead of ignoring the potential error
>> detected by credential_from_url() and using credential when it is
>> available, we loudly attempt to parse and give warning on malformed
>> entries when we discard a line?
>
> the idea was to silently ignore the line (notice quiet = 1), which

Ah, sorry, I apparently did not read the patch carefully enough.

Thanks for a correction.