From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Aug 2020 22:50:47 GMT
Subject: Re: [PATCH v3 1/2] revision: differentiate if --no-abbrev asked explicitly
Message-ID: <xmqq4koycks8.fsf@gitster.c.googlers.com>
In-Reply-To: <20200814145043.GB9518@danh.dev>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

>> What am I missing?
>
> No, you didn't miss anything.
>
> It's obviously me, who screwed up the logical thinking.
>
> Originally, I come up with something along the line in 2/2:
>
> 	int abbrev = o->flags.full_index ? hexsz : DEFAULT_ABBREV;
> 	if (!o->abbrev)
> 		abbrev = o->abbrev;
>
> I couldn't recalled what I wrote, but that logic requires 1/2,
> after I come up with 1/2, I re-analysed 2/2 and come up with current
> logic.
>
> I failed to re-visit 1/2 to check if it's necessary.
> It's all MY fault.
>
> Sorry for wasting everyone's time in 1/2.
>
> Please eject 1/2 from this series.

OK.  2/2 would work without this step.