From: Junio C Hamano Date: Fri, 29 Jan 2021 23:19:41 GMT Subject: Re: [PATCH v2 1/1] MacOS: precompose_argv_prefix() Message-ID: In-Reply-To: <20210129171512.28167-1-tboegi@web.de> tboegi@web.de writes: > Solution: > precompose_argv() now handles the prefix (if needed), and is renamed into > precompose_argv_prefix(). > > Inside this function the config variable core.precomposeunicode is read > into the global variable precomposed_unicode, as before. > This reading is skipped if precomposed_unicode had been read before. > > The original patch for preocomposed unicode, 76759c7dff53, placed > precompose_argv() into parse-options.c > Now move it into git.c . > As a cleanup, remove it from parse-options.c and diff*.c So an effect of this change is that now everybody's argv[], not just those who are using parse-options API, is munged at the same single place. That sounds like a good move toward a happy future. Will queue. Thanks.