From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Feb 2021 18:11:56 GMT
Subject: Re: [PATCH 21/25] pickaxe: use PCREv2 for -G and -S
Message-ID: <xmqq4kir8zyr.fsf@gitster.c.googlers.com>
In-Reply-To: <87y2g4dgpc.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> There's a bug here where now different things are dispatched to either
> the -S or -G codepath wrongly, I've fixed it in my local version.
>
> Anyway, it's interesting between this and the -U0 change that we have
> little/no coverage for some/all of this. I'm trying to address that in
> preceding patches in v2.

Back when I did the original -S<fixed>, we weren't as focused on
good test coverage as we are now.  We may have added a lot more by
the time when we introduced -G and -S<regexp>, but your effort that
resulted in noticing the lack of basic coverage and rectifying the
situation is very much appreciated.

Thanks.