From: Junio C Hamano Date: Wed, 24 Nov 2021 01:37:16 GMT Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' Message-ID: In-Reply-To: <20211123185237.M476855@dcvr> Eric Wong writes: > git send-email's capitalization does annoy me and I've looked > into changing it; but there's a bunch of tests and probably > dependent code that also need to be updated... It does annoy me, too, and I do not mind if it gets "fixed", but I do not know if the cost for vetting a bulk update like that is worth it. There is another one outside send-email in log-tree.c that is responsible for output from format-patch. Here is the extent of damage in my trial change that seems to pass the tests locally. Documentation/MyFirstContribution.txt | 14 ++++----- Documentation/git-format-patch.txt | 4 +-- Documentation/git-send-email.txt | 2 +- git-send-email.perl | 4 +-- log-tree.c | 2 +- mailinfo.c | 4 +-- t/t4014-format-patch.sh | 56 +++++++++++++++++------------------ t/t4150-am.sh | 8 ++--- t/t4258/mbox | 2 +- t/t5100/msg0002 | 2 +- t/t5100/msg0003 | 2 +- t/t5100/msg0012--message-id | 2 +- t/t5100/quoted-cr.mbox | 4 +-- t/t5100/sample.mbox | 6 ++-- t/t9001-send-email.sh | 38 ++++++++++++------------ 15 files changed, 75 insertions(+), 75 deletions(-) diff --git i/Documentation/MyFirstContribution.txt w/Documentation/MyFirstContribution.txt index b20bc8e914..91cb204d52 100644 --- i/Documentation/MyFirstContribution.txt +++ w/Documentation/MyFirstContribution.txt @@ -1071,21 +1071,21 @@ between your last version and now, if it's something significant. You do not need the exact same body in your second cover letter; focus on explaining to reviewers the changes you've made that may not be as visible. -You will also need to go and find the Message-Id of your previous cover letter. +You will also need to go and find the Message-ID of your previous cover letter. You can either note it when you send the first series, from the output of `git send-email`, or you can look it up on the https://lore.kernel.org/git[mailing list]. Find your cover letter in the -archives, click on it, then click "permalink" or "raw" to reveal the Message-Id +archives, click on it, then click "permalink" or "raw" to reveal the Message-ID header. It should match: ---- -Message-Id: +Message-ID: ---- -Your Message-Id is ``. This example will be used -below as well; make sure to replace it with the correct Message-Id for your -**previous cover letter** - that is, if you're sending v2, use the Message-Id -from v1; if you're sending v3, use the Message-Id from v2. +Your Message-ID is ``. This example will be used +below as well; make sure to replace it with the correct Message-ID for your +**previous cover letter** - that is, if you're sending v2, use the Message-ID +from v1; if you're sending v3, use the Message-ID from v2. While you're looking at the email, you should also note who is CC'd, as it's common practice in the mailing list to keep all CCs on a thread. You can add diff --git i/Documentation/git-format-patch.txt w/Documentation/git-format-patch.txt index 113eabc107..daf911f249 100644 --- i/Documentation/git-format-patch.txt +++ w/Documentation/git-format-patch.txt @@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`. If given `--thread`, `git-format-patch` will generate `In-Reply-To` and `References` headers to make the second and subsequent patch mails appear -as replies to the first mail; this also generates a `Message-Id` header to +as replies to the first mail; this also generates a `Message-ID` header to reference. OPTIONS @@ -163,7 +163,7 @@ include::diff-options.txt[] --no-thread:: Controls addition of `In-Reply-To` and `References` headers to make the second and subsequent mails appear as replies to the - first. Also controls generation of the `Message-Id` header to + first. Also controls generation of the `Message-ID` header to reference. + The optional