From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Dec 2021 04:13:43 GMT
Subject: Re: [PATCH 10/10] reftable: make reftable_record a tagged union
Message-ID: <xmqq4k7j68eg.fsf@gitster.g>
In-Reply-To: <YbAVOtYXA1Hf9EtJ@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> error: ISO C99 doesn't support unnamed structs/unions [-Werror=pedantic]
>
> Hmm. It's interesting that the regular DEVELOPER=1 doesn't catch this.
> It's because we don't specify -std there, and newer gcc defaults to
> gnu17 (unnamed unions appeared in c11, I think). I wonder if it would be
> helpful to teach config.mak.dev to pass -std=c99.

FWIW, I use -std=gnu99 as our Makefile suggests.