From: Junio C Hamano Date: Wed, 22 Dec 2021 19:59:27 GMT Subject: Re: [PATCH v2 0/6] usage API: Add and use die_message() Message-ID: In-Reply-To: <20211222185715.1090524-1-jonathantanmy@google.com> Jonathan Tan writes: >> A small set of fixes to usage.[ch]'s API use that will go towards >> enabling nicer things down the road. See [1] for the v1 summary >> >> I believe this should address all the feedback Junio had on the >> v1. >> >> Aside from the substantially rewritten 6/6 and much simplified 4/6 the >> end-state is almost the same, but things are better split up, >> explained etc. now. >> >> 1. https://lore.kernel.org/git/cover-0.4-00000000000-20211206T165221Z-avarab@gmail.com/ > > I haven't looked at this round of patches yet, but for the convenience > of reviewers, it would have been great if you linked to a prior > discussion [1], including an email from me with comments that (as far as > I know) haven't been addressed [2]. > > [1] https://lore.kernel.org/git/patch-1.1-5a47bf2e9c9-20211021T114223Z-avarab@gmail.com/ > [2] https://lore.kernel.org/git/20211027215053.2257548-1-jonathantanmy@google.com/ Hear, hear, and thanks.