From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 24 Mar 2022 04:43:05 GMT
Subject: Re: [PATCH v2 06/27] revision.[ch]: provide and start using a release_revisions()
Message-ID: <xmqq4k3om04m.fsf@gitster.g>
In-Reply-To: <patch-v2-06.27-7194aac88e1-20220323T203149Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> diff --git a/revision.c b/revision.c
> index 303d1188207..90bac9ada03 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -2933,6 +2933,13 @@ static void release_revisions_commit_list(struct rev_info *revs)
>  	revs->commits = NULL;
>  }
>  
> +void release_revisions(struct rev_info *revs)
> +{
> +	if (!revs)
> +		return;
> +	object_array_clear(&revs->pending);
> +}

Yay.

It is unclear why we want to allow passing NULL to this, though.  Do
we even have any code paths that allocate on-heap rev-info?  Address
of an on-stack or global rev_info will never be NULL.