From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Jun 2022 22:34:29 GMT
Subject: Re: [PATCH 3/3] config tests: fix harmless but broken "rm -r" cleanup
Message-ID: <xmqq4k0dfxxm.fsf@gitster.g>
In-Reply-To: <patch-3.3-f787b19f8c2-20220621T221928Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

>  test_expect_success 'override global and system config' '
> -	test_when_finished rm -f "$HOME"/.config/git &&
> +	test_when_finished "rm -rf \"$HOME\"/.config/git" &&

As this string is evaled, isn't it safer to defer dereferencing the
environment variable at the runtime by quoting the dollar-sign, too?

I.e.

	test_when_finished rm -rf \"\$HOME\"/.config/git &&

or something?