From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Apr 2023 16:22:36 GMT
Subject: Re: [PATCH] gpg-interface: set trust level of missing key to "undefined"
Message-ID: <xmqq4jp5gshf.fsf@gitster.g>
In-Reply-To: <20230422104758.GA2969939@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So before my patch the uninitialized state is (supposedly) less than the
> min level, and after they are the same. For the reasons I gave in the
> commit message, I think that less-than comparison was already broken.
> And likewise, for the reasons I gave, it hopefully never matters since
> the result would never be 'G' in that case.

Yes * 2.

> So I think it's fine, but I definitely had to stare at it for a while.
> This all comes from 54887b4689 (gpg-interface: add minTrustLevel as a
> configuration option, 2019-12-27), which does discuss some of the
> implications, but I think my patch is in line with the logic there.

Yes.

Thanks.