From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Apr 2023 17:49:32 GMT
Subject: Re: [PATCH v8 6/6] notes.c: introduce "--[no-]stripspace" option
Message-ID: <xmqq4jp326oj.fsf@gitster.g>
In-Reply-To: <f60f743203d78a489b90df81472e71391b45367d.1682429602.git.dyroneteng@gmail.com>

Teng Long <dyroneteng@gmail.com> writes:

> From: Teng Long <dyroneteng@gmail.com>
>
> This commit introduces a new option "--[no-]stripspace" to git notes
> append, git notes edit, and git notes add. This option allows users to
> control whether the note message need to stripped out.

Makes sense.

>     ... One more thing need to note is "the order of
>     the options matter", that is, if you specify "-C" before "-m" or
>     "-F", the reused message by "-C" will be stripped out together,
>     because everytime concat "-m" or "-F" message, the concated message
>     will be stripped together. Oppositely, if you specify "-m" or "-F"
>     before "-C", the reused message by "-C" will not be stripped out.

This sounds more like a design/implementation mistake that we may
want to fix.