From: Junio C Hamano Date: Mon, 12 Jun 2023 21:42:33 GMT Subject: Re: [PATCH v2 19/25] completion: complete --patch-with-raw Message-ID: In-Reply-To: <807b8201d145a21c629797067cee21d1d1b9a0d4.1686574374.git.gitgitgadget@gmail.com> "Philippe Blain via GitGitGadget" writes: > From: Philippe Blain > > Signed-off-by: Philippe Blain > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Everything else in the series looked OK, but I am not sure if we want to advertise this historical wart that has no practical advantage over using "-p --raw". The only reason why we kept it is because we do not have to even think about how likely it will break ancient scripts if we removed it. Thanks. > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index a69421cd740..c0d2678d320 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1741,7 +1741,7 @@ __git_diff_common_options="--stat --numstat --shortstat --summary > --color-moved-ws= --no-color-moved-ws > --full-index --binary --abbrev --diff-filter= > --find-copies --find-object --find-renames > - --no-relative --relative > + --no-relative --relative --patch-with-raw > --find-copies-harder --ignore-cr-at-eol > --text --ignore-space-at-eol --ignore-space-change > --ignore-all-space --ignore-blank-lines --exit-code