From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Aug 2023 17:10:42 GMT
Subject: Re: [PATCH v5 0/3] check-attr: integrate with sparse-index
Message-ID: <xmqq4jl1lfcd.fsf@gitster.g>
In-Reply-To: <3b2a5b4b-ab8f-746b-6b69-8e8262b6390b@github.com>

Victoria Dye <vdye@github.com> writes:

> Shuqi Liang wrote:
>> change against v4:
>
> I've reviewed the patches in this version and all of my prior feedback
> appears to be addressed. Overall, I think this is ready to merge. 
>
> I see that you didn't take the suggestion from [1], though. I personally
> don't consider it a blocking issue, but I am curious to hear your
> thoughts/reasoning behind sticking with your current patch organization over
> what was suggested there.
>
> [1] https://lore.kernel.org/git/kl6la5v82izn.fsf@chooglen-macbookpro.roam.corp.google.com/
>
> Otherwise, a couple notes:

Thanks for a review Victoria, and Shuqi, thanks for working on the
topic.

I too am curious what your response to [1] would be, by the way.