From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 05 Oct 2023 20:25:28 GMT
Subject: Re: [PATCH v2 3/3] builtin/repack.c: implement support for `--max-cruft-size`
Message-ID: <xmqq4jj4izpj.fsf@gitster.g>
In-Reply-To: <ZR6nKzflu_18JnoG@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

> On Mon, Oct 02, 2023 at 08:44:32PM -0400, Taylor Blau wrote:
> [snip]
>> diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt
>> index 90806fd26a..fa0541b416 100644
>> --- a/Documentation/git-gc.txt
>> +++ b/Documentation/git-gc.txt
>> @@ -59,6 +59,13 @@ be performed as well.
>>  	cruft pack instead of storing them as loose objects. `--cruft`
>>  	is on by default.
>>  
>> +--max-cruft-size=<n>::
>> +	When packing unreachable objects into a cruft pack, limit the
>> +	size of new cruft packs to be at most `<n>`. Overrides any
>
> We should probably mention the unit here, which is bytes.

Good suggestion.  I'll tweak "at most `<n>`" to "& bytes" or
something.