From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 09 Jan 2024 22:34:38 GMT
Subject: Re: [PATCH v7 1/1] mingw: give more details about unsafe directory's ownership
Message-ID: <xmqq4jfmf85d.fsf@gitster.g>
In-Reply-To: <e7594386-4a26-467d-bd27-8ac6268ad219@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>> Because len_domain includes the terminating NUL for the domain part,
>> (*str)[len_domain-1] is that NUL, no?  And that is what you want to
>> overwrite to make the two strings <d> <NUL> <u> <NUL> into a single
>> one <d> <slash> <u> <NUL>.  So...
>
> But after a successful call, len_domain and len_user have been modified
> to contain the lengths of the names (not counting the NULs), ...

Ah, that is what I missed.  Thanks.