From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 19 Feb 2024 21:24:47 GMT
Subject: Re: [PATCH v4 0/3] apply with core.filemode=false
Message-ID: <xmqq4je46tb4.fsf@gitster.g>
In-Reply-To: <fd8264c0-3080-c9d9-cac5-51115b9909a5@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> > Chandra Pratap (1):
>> >   apply: ignore working tree filemode when !core.filemode
>> >
>> > Junio C Hamano (2):
>> >   apply: correctly reverse patch's pre- and post-image mode bits
>> >   apply: code simplification
>> >
>> >  apply.c                   | 16 +++++++++++++---
>> >  t/t4129-apply-samemode.sh | 27 +++++++++++++++++++++++++++
>> >  2 files changed, 40 insertions(+), 3 deletions(-)
>>
>> Anybody wants to offer a review on this?  I actually am fairly
>> confortable with these without any additional review, but since I am
>> sweeping the "Needs review" topics in the What's cooking report, I
>> thought I would ask for this one, too.
>
> I just had a look over all three of the patches, and to me, they look good
> to go.

Thanks.