From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Dec 2024 20:25:57 GMT
Subject: Re: [PATCH v4 6/8] refs: introduce the `ref_transaction_update_reflog` function
Message-ID: <xmqq4j2zifmy.fsf@gitster.g>
In-Reply-To: <8734ijh3jg.fsf@iotcl.com>

Toon Claes <toon@iotcl.com> writes:

>> +		const char *what = flags & REF_LOG_ONLY ? "reflog for pseudoref" : "pseudoref";
>
> These strings are not localized.
>
>> +		strbuf_addf(err, _("refusing to update %s '%s'"), what, refname);
>>  		return 0;

And the structure forces sentence logo.  If "reflog for pseudoref"
were masculine and "pseudoref" were feminine in a language where the
verb "update" conjugates differently based on its object, the
resulting construction cannot be translated.  Rather, we'd need to
do something uglier like this:

	const char *refusal_msg;
	if (flag & REF_LOG_ONLY)
		refusal_msg = _("refusing to update reflog for pseudoref '%s'");
	else
		refusal_msg = _("refusing to update pseudoref '%s'");
	...
	strbuf_addf(err, refusal_msg, refname);