From: Junio C Hamano Date: Fri, 23 Oct 2026 18:52:09 GMT Subject: Re: [PATCH v5 0/6] connected: add incremental connectivity check Message-ID: In-Reply-To: "Kristofer Karlsson via GitGitGadget" writes: > Next steps > ========== > > This series only addresses tree verification; the other significant cost is > finding the commit boundary, especially for repos with many refs. I already > have some prototypes for optimizing that too, and if this ends up landing, > that would be something I would start polishing up. > > > Changes since v4 > ================ > > * The series no longer touches repo->fetch_if_missing, which Junio pointed > out was a trap when cleared only for some modes. The incremental verifier > instead reads blobs and trees with odb_read_object_info_extended() and > OBJECT_INFO_SKIP_FETCH_OBJECT, so it never lazily fetches on its own; > commit parsing already never fetches. The BUG() guard on the flag is > gone, and parse_connectivity_check() no longer takes a repository. The > full check is unchanged: in a partial clone check_connected() passes > --exclude-promisor-objects as before. > * A tree that cannot be read because it is corrupt is now reported as an > error, like a corrupt blob, instead of dying. Thanks, these incremental changes look good. Will replace.