From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Mar 2014 18:22:58 GMT
Subject: Re: [PATCH 04/10] t4209: use helper functions to test --grep
Message-ID: <xmqq38i7qwvx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1395508560-19893-5-git-send-email-l.s.r@web.de>

René Scharfe <l.s.r@web.de> writes:

> -test_expect_success 'log --grep -i' '
> -	git log -i --grep=InItial --format=%H >actual &&
> -	test_cmp expect_initial actual
> -'
> +test_log	expect_initial	--grep initial
> +test_log	expect_nomatch	--grep InItial

This, and the next --author one, assumes that we will never break
"--grep=foo" without breaking "--grep foo".  That should be OK, but
we might want to add separate tests e.g.

	test_log expect_initial --grep=initial

perhaps?  I dunno.

Queued without any tweaks for now.  Thanks.