From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 14 Aug 2014 17:00:16 GMT
Subject: Re: [PATCH v3 6/6] diff: shortcut for diff'ing two binary SHA-1 objects
Message-ID: <xmqq38cz2ehr.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1407927454-9268-7-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> diff --git a/t/t1050-large.sh b/t/t1050-large.sh
> index 711f22c..b294963 100755
> --- a/t/t1050-large.sh
> +++ b/t/t1050-large.sh
> @@ -116,6 +116,14 @@ test_expect_success 'diff --stat' '
>  	git diff --stat HEAD^ HEAD
>  '
>  
> +test_expect_success 'diff' '
> +	git diff HEAD^ HEAD
> +'
> +
> +test_expect_success 'diff --cached' '
> +	git diff --cached HEAD^
> +'

What are these checking?  No check for their outcome?

>  test_expect_success 'hash-object' '
>  	git hash-object large1
>  '