From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Dec 2014 17:37:43 GMT
Subject: Re: [PATCH] refs: release strbuf after use in check_refname_component()
Message-ID: <xmqq387y1hnc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <549A0665.6080207@web.de>

René Scharfe <l.s.r@web.de> writes:

> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  refs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/refs.c b/refs.c
> index 5fcacc6..ed3b2cb 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -2334,7 +2334,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
>  			struct strbuf err = STRBUF_INIT;
>  			unable_to_lock_message(ref_file, errno, &err);
>  			error("%s", err.buf);
> -			strbuf_reset(&err);
> +			strbuf_release(&err);
>  			goto error_return;
>  		}
>  	}

The subject does not seem to match what the patch is doing, but the
patch is obviously correct ;-)