From: Junio C Hamano Date: Mon, 08 Jun 2015 17:05:19 GMT Subject: Re: [WIP/PATCH v5 05/10] for-each-ref: introduce 'ref_array_clear()' Message-ID: In-Reply-To: Matthieu Moy writes: > Karthik Nayak writes: > >> On 06/08/2015 08:23 PM, Matthieu Moy wrote: >>> Karthik Nayak writes: >>> >>> > +/* Free all memory allocated for ref_array */ >>> > +void ref_array_clear(struct ref_array *array) >>> >>> Is this a private function? If so, then add static. If not, you probably >>> want to export it in a .h file. >>> >> It is in ref-filter.h. > > Ah, OK. It comes later in the series. Confused I am; if it comes later not in the same patch then it is not OK, is it?