From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 30 Jun 2015 16:22:18 GMT
Subject: Re: [PATCH 3/3] introduce "format" date-mode
Message-ID: <xmqq381988ud.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150630102055.GA11928@peff.net>

Jeff King <peff@peff.net> writes:

>> 	strbuf_addf(&f, "%s ", fmt);
>
> Basically I was trying to avoid making any assumptions about exactly how
> strftime works. But presumably "stick a space in the format" is a
> universally reasonable thing to do. It's a hack, but it's contained to
> the function.

Why can't I shake this feeling that (" %s", fmt), i.e. prepend not
append, is the safer thing to do than to append?