From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 17 Sep 2015 22:09:19 GMT
Subject: Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options
Message-ID: <xmqq37ycitps.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150917213619.GI17201@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

>> +--[no-]merged [<commit>]::
>
> We prefer to write --[no-]* as:
>
> 	--option::
> 	--no-option::
>
> although this may be the first instance that we see this combination
> with an argument.
>
> I also found the "[<commit>]" syntax confusing and had to go and figure
> out what PARSE_OPT_LASTARG_DEFAULT does; I wonder if it's worth
> appending something like the following to the help for this option:
>
> 	The `commit` may be omitted if this is the final argument.

"may be omitted" must be followed by a description of what happens
when omitted (i.e. "defaults to ...").