From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Apr 2016 17:52:48 GMT
Subject: Re: [PATCH v2] git-p4: add P4 jobs to git commit message
Message-ID: <xmqq37qh32q7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqshyi2yb7.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Not a new problem in this script, but we'd prefer to spell this as
>
>     p4_add_job () {
>
> i.e. a space on both sides of ().
>
>> +	name=$1 &&
>> +	p4 job -f -i <<-EOF
>> +	Job: $name
>> +	Status: open
>> +	User: dummy
>> +	Description:
>> +	EOF
>> +}
>
> It may be better without $name?

Just so that I won't get misunderstood, with this I do not mean
"Job: $name" line does not have to be there.  I meant that there is
no need to use name variable in this function; just writing $1
instead of $name there is better, as $name is not a function local
variable in POSIX shells.