From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 27 Oct 2016 04:13:39 GMT
Subject: Re: [PATCHv2 1/2] attr: convert to new threadsafe API
Message-ID: <xmqq37jia0p8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kYiVxJwtAYsgks8LVNWvawWxdy=8Xpdrki-C_u15C3Z9w@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> Yeah, I can make it work without exposing struct git_attr.

You completely misunderstood me.  "struct git_attr" MUST be visible
to the users so that they can ask for the name in git_check.attr[0].

What would be nice to hide if you can is the function to intern a
string into a pointer to struct git_attr, i.e. git_attr() function.