From: Junio C Hamano Date: Mon, 19 Dec 2016 01:12:18 GMT Subject: Re: [PATCH] winansi_isatty(): fix when Git is used from CMD Message-ID: In-Reply-To: Johannes Sixt writes: > .. > The new isatty() override implemented by cbb3f3c9b197 (mingw: intercept > isatty() to handle /dev/null as Git expects it, 2016-12-11) does not > take into account that _get_osfhandle() returns the handle visible by > the C code, which is the pipe. But it actually wants to investigate the > properties of the handle that is actually connected to the outside > world. Fortunately, there is already winansi_get_osfhandle(), which > returns exactly this handle. Use it. > > Signed-off-by: Johannes Sixt > --- > I was able to test the idea earlier than anticipated and it does work > for me. I'll queue this in 'pu' so that I won't forget, but this time I'll make sure I won't act on it until I see you two agree on the right way forward. Thanks.