From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Oct 2017 00:59:38 GMT
Subject: Re: [PATCH] builtin/push.c: add push.pushOption config
Message-ID: <xmqq3769bbt1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171023114449.11902-1-marius.paliga@gmail.com>

Marius Paliga <marius.paliga@gmail.com> writes:

> Push options need to be given explicitly, via the command line as "git
> push --push-option <option>".  Add the config option push.pushOption,
> which is a multi-valued option, containing push options that are sent
> by default.
>
> When push options are set in the lower-priority configulation file
> (e.g. /etc/gitconfig, or $HOME/.gitconfig), they can be unset later in
> the more specific repository config by the empty string.
>
> Add tests and update documentation as well.
>
> Signed-off-by: Marius Paliga <marius.paliga@gmail.com>
> ---

Looks good.

> +This is a multi-valued variable, and an empty value can be used in a
> +higher priority cofiguration file (e.g. `.git/config` in a

s/cofig/config/; I think you inherited from me, sorry.

I'll tweak it while queuing; there is not need to resend only to fix
this.

Thanks.