From: Junio C Hamano Date: Mon, 14 May 2018 06:45:30 GMT Subject: Re: [PATCH v2 11/14] show-branch: use commit-slab for commit-name instead of commit->util Message-ID: In-Reply-To: <20180513055208.17952-12-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > It's done so that commit->util can be removed. See more explanation in > the commit that removes commit->util. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/show-branch.c | 39 +++++++++++++++++++++++++++------------ > 1 file changed, 27 insertions(+), 12 deletions(-) Looks obviously correct. Another place we could use commit-slab in this program, which I think is a more interesting application, is to use it to store a bitmask with runtime-computed width to replace those object->flags bits, which will allow us to lift the MAX_REVS limitation. Thanks.