From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Nov 2018 03:37:32 GMT
Subject: Re: [PATCH 2/3] tests: mark those tests where "git fsck" fails at the end
Message-ID: <xmqq36slv56r.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181031124208.29451-3-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Mark the tests where "git fsck" fails at the end with extra test code
> to check the fsck output. There fsck.{err,out} has been created for
> us.
>
> A later change will add the support for GIT_TEST_FSCK_TESTS. They're
> being added first to ensure the test suite will never fail with
> GIT_TEST_FSCK=true during bisect.

I am sympathetic to what step 3/3 (eh, rather, an earlier "let's not
leave the repository in corrupt state, as that would make it
inconvenient for us to later append new tests") wants to do, but not
this one---these markings at the end makes it inconvenient for us to
later add new tests to these script before them.