From: Junio C Hamano Date: Tue, 19 Nov 2019 01:29:10 GMT Subject: Re: [PATCH 0/8] build-in add -i: implement all commands in the main loop Message-ID: In-Reply-To: Johannes Schindelin writes: >> Preparing the "add -p" machinery in such a way that "add -i" merely >> is one of the users would make a lot of sense from organizational >> point of view. > > If I understand you correctly, you mean that e.g. `git checkout -p` will > call the code from `add-patch.c` directly?... Yup, and it is a good organization that the "add -p" machinery is held not too intimate with the rest of "add -i" but treats "add -i" as just one of its users from the beginning, which is what you did here. In case it wasn't clear, I am saying that I like the resulting organization of these 8 patches.