From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 31 Jan 2020 21:03:28 GMT
Subject: Re: [PATCH v2] C: use skip-prefix to avoid hardcoded string length
Message-ID: <xmqq36bv9w4f.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACayv=hcH=dvfup2fzm5-OKYxEyC1m7YBTfpm=6z0BhO=hK-cQ@mail.gmail.com>

Andrei Rybak <rybak.a.v@gmail.com> writes:

> On 1/30/20 8:35 PM, Junio C Hamano wrote:
>> We often skip an optional prefix in a string with a hardcoded
>> constant, e.g.
>>
>>       if (starts_with(string, "prefix"))
>>               string += 6;
>>
>> which is less error prone when written
>>
>>       skip_prefix(string, "prefix", &string);
>
> Should the subject line say "skip_prefix" with an underscore instead of
> "skip-prefix" with a dash?

Perhaps.  Or "skip_prefix()" to clarify that we are talking about a
function.