From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 24 Jan 2021 00:22:03 GMT
Subject: Re: [PATCH v3 2/7] bisect--helper: reimplement `bisect_replay` shell function in C
Message-ID: <xmqq35yr2nh0.fsf@gitster.c.googlers.com>
In-Reply-To: <20210123154056.48234-3-mirucam@gmail.com>

Miriam Rubio <mirucam@gmail.com> writes:

> From: Pranit Bauva <pranit.bauva@gmail.com>
>
> Reimplement the `bisect_replay` shell function in C and also add
> `--bisect-replay` subcommand to `git bisect--helper` to call it from
> git-bisect.sh
> ...
> +static int process_replay_line(struct bisect_terms *terms, struct strbuf *line)
> +{
> +	const char *p = line->buf + strspn(line->buf, " \t");
> +
> +	if ((!skip_prefix(p, "git bisect", &p) &&
> +	!skip_prefix(p, "git-bisect", &p)) || !isspace(*p))
> +		return 0;
> +	p += strspn(p, " \t");
> +
> +	char *word_end = (char*)p + strcspn(p, " \t");
> +	char *rev = word_end + strspn(word_end, " \t");

Are these lines new in this round?

These break builds with -Werror=declaration-after-statement.